Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/18678
Note: Links to docs will display an error until the docs builds have been completed. ❌ 2 New Failures, 3 Unrelated FailuresAs of commit b134db8 with merge base 3d2c853 ( NEW FAILURES - The following jobs have failed:
FLAKY - The following jobs failed but were likely due to flakiness present on trunk:
BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
suryasidd
requested review from
JacobSzwejbka,
kirklandsign and
larryliu0820
as code owners
meta-cla
bot
added
the
CLA Signed
This PR needs a
|
There was a problem hiding this comment.
Pull request overview
This PR enables Windows support for the OpenVINO backend by adding Windows-specific dynamic library discovery/loading paths and updating build/docs accordingly.
Changes:
- Add Windows OpenVINO runtime auto-discovery in Python bindings (DLL path + DLL directory handling).
- Add Windows dynamic loading support in the C++ OpenVINO runtime (LoadLibrary/GetProcAddress + FreeLibrary).
- Update OpenVINO backend build flags for MSVC and extend README instructions for Windows.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| extension/pybindings/portable_lib.py | Detect openvino_c.dll on Windows and set OPENVINO_LIB_PATH / DLL search directory. |
| backends/openvino/runtime/OpenvinoBackend.cpp | Use LoadLibrary/GetProcAddress on Windows; keep dlopen/dlsym on non-Windows. |
| backends/openvino/runtime/OpenvinoApi.h | Add Windows header include and close library handles via FreeLibrary on Windows. |
| backends/openvino/README.md | Document Windows quick start, env var setup, and build steps. |
| backends/openvino/CMakeLists.txt | Use MSVC-compatible RTTI/exception flags (/GR, /EHsc) on Windows. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| ``` | ||
| 2. **Clone ExecuTorch Repository from GitHub** | ||
| - On Windows, enable symlinks before cloning. Refer to [Building from Source](https://docs.pytorch.org/executorch/main/using-executorch-building-from-source.html#environment-setup) for more details. | ||
| - Clone Executorch repository by executing the command below. |
There was a problem hiding this comment.
Typo/inconsistent product name: this should say “ExecuTorch repository” (consistent with the rest of the doc) rather than “Executorch repository”.
| - Clone Executorch repository by executing the command below. | |
| - Clone ExecuTorch repository by executing the command below. |
Summary
This PR enables windows support for OpenVINO backend in executorch.